Adding Amazon Datasets to MLDatasets.jl

General Usage
1

Hi everyone,

I’m new to contributing to the Julia developer community on GitHub, although I’ve been using Julia for some time. I recently opened my first pull request to MLDatasets.jl to add a dataset, and I wanted to better understand the review process.

My PR has passed all the tests and checks, and I’d really appreciate any feedback or suggestions if something should be improved.

PR #249: Add AmazonComputers and AmazonPhoto graph datasets by Uneeb808 · Pull Request #249 · JuliaML/MLDatasets.jl · GitHub

I also had a few general questions about the contribution process:

  1. Approximately how long does it usually take for a pull request to be reviewed?
  2. If a PR does not receive a review for a long time, what is the appropriate way to follow up?

I’d be grateful for any guidance, and I’m happy to make any changes if needed.

Thanks!

2

I think it’s hard to give a generic answer, as it really depends on the package…

3

I agree with the answer above. It depends on the maintainers of the package.

In the future, it might be prudent to open an issue and propose a PR to ensure that the maintainers are amenable to your idea idea and will have the bandwidth to review your PR. Otherwise, there is some risk that your PR is not approved for some reason.

4

Quick update — the PR got merged! Thanks a lot for the advice, really helped. And yeah, noted on opening an issue first before jumping into a PR next time.

1 Like