Yggdrasil build has a bug on Windows

joa-quim · July 11, 2024, 12:43pm

Hi,

Maybe not the best place to ask/report this but don’t know a better one.

In Yggdrasil the compilation of GMT on Windows is bugged. The simple function

GenericMappingTools/gmt/blob/master/src/gmt_io.c#L9427


      
          		if (text[i] == '-') n_minus++;
          	}
          	if (n_digits == 0 || n_period > 1 || (n_plus + n_minus) > 2) return (true);
          	if (n_period) {	/* Check if we have filename.ext with ext having no numbers */
          		for (i = period + 1, n_digits = k = 0; text[i]; i++, k++) if (isdigit ((int)text[i])) n_digits++;
          		if (k > 0 && n_digits == 0) return (true);	/* Probably a file */
          	}
          	return (false);	/* This may in fact be numeric */
          }
          
          bool gmt_is_float (struct GMT_CTRL *GMT, char *text) {
          	/* Returns true if text is a valid floating point number.
          	 * Only called if we know text is not longitude or time, etc. */
          	int len;
          	double dummy = 0.0;
          	gmt_M_unused(GMT);
          
          	if (sscanf (text, "%lf %n", &dummy, &len) == 1 && len == (int)strlen(text))
          		return true;
          	else {
          #if defined(__MINGW32__)

returns false when it should true true, and this only happened with the Yggdrasil build on Windows. That function works well for all other OSs, it works well on my local MSVC build and even if build a similar one locally with MinGW.

This returns true in all but the Yggdrasil build for Windows. In the mention function (gmt_is_float()) I even added an extra test for the MinGW compiler, but it still fails

ccall((:gmt_is_float, GMT.libgmt), Bool, (Cstring, Ptr{UInt8}), GMT.GMT_Get_Ctrl(GMT.G_API[1]), "0.25")