Understanding changes from Case Study: Rational Conversions

history

#1

Hello!

How do I find the issue commenting on the changes made from
https://docs.julialang.org/en/stable/manual/conversion-and-promotion/#man-rational-conversion-1 to https://github.com/JuliaLang/julia/blob/master/base/rational.jl#L88-L97?

Thanks!


#2

So you’re looking to find the discussion on GitHub that led to those changes being implemented? If that’s the case, here’s what I do. It’s likely not the most efficient way, but it gets the job done. :slightly_smiling_face:

  1. Look at the Git blame information using the GitHub UI. To do this, highlight a line then go up to the top of the page and click “Blame” (between “Raw” and “History”). This shows you the commits that last touched each line.

  2. In the commit history for the relevant line(s), look for a commit message that at least somewhat relates to the change you’re looking for. From this you should be able to get the PR number that included that commit.

  3. Look through the comments in the PR to see if it’s what you’re looking for. You can also check any issues that may be linked in the PR. If what you’ve found isn’t quite relevant, go back to step 1 and repeat.

I hope that helps at least somewhat.