Binning strategies like tree-based domain decomposition could reduce it further, but I don’t think there’s a much better approach (at least from a finite element toolbox).
This isn’t done often in FEM because relevant points in a simplex are usually mapped from a reference simplex explicitly.
The package VoronoiDelaunay.jl has a method locate whose source implementation seems quite similar to your example code, which seems like a reasonable indication that your approach is workable.
EDIT: looking at the code for a minute, their findindex function is a custom function (at a glance I assumed it was something in Base). It is slightly more clever and looks to use a tree-like method to search more efficiently. So a bit more thoughtful than a brute-force search.