So I am wondering if import Base: max max(a) = max(a...) export max would be safe, after all I am extending the “concept” to vectors or NTuples. Bu then it may well be a rather stupid thing to do, and have serious side effects that I am unaware…

Splatting (a...) is slow for long arrays. There is maximum that does what you implement.

[image] askvorts: it may well be a rather stupid thing to do Extending Base.max in this way would be “type piracy” , which is typically a bad idea because it has side effects on unrelated code. (Aside from the fact that this is what maximum is for, or that splatting large collections is bad.…

reduce(max, xs) also works for this.

It’s also quite confused in terms of its own meaning. What should max([[1,2]]) be? What about max([[1,2],[3,4]])? Or max([[[1,2]]])? This is precisely why Julia separates out the concepts of max from maximum.

And to mention the last edge case: What should max([]) (which would result in max()) be?

Wondering if extending Base: max with max(a) = max(a...) would be safe?!

General Usage

stevengj March 12, 2025, 10:02pm 7

Presumaby the same as maximum of an empty collection, which currently throws; see also Extend the domain of maximum and minimum to include empty collection? - #3 by klacru

Topic		Replies	Views
Max and maximum: why the difference? General Usage	10	19151	October 15, 2017
Extend the domain of maximum and minimum to include empty collection? Internals & Design question , proposal	24	4033	December 22, 2019
Max of a vector New to Julia question	31	10273	February 24, 2025
Understand the pattern of multiple dispatch General Usage question	4	2240	September 20, 2017
`Base.max(::Int, ::Int) = nothing` crashes Julia New to Julia	7	305	June 9, 2024

Wondering if extending Base: max with max(a) = max(a...) would be safe?!

Related topics