Rem2pi(pi) errors

jerlich · October 9, 2025, 1:42pm

There is a PR to fix, but it hasn’t been merged for 2 years.

github.com/JuliaLang/julia

Add Irrational support to rem2pi

master ← garrison:rem2pi-irrational

opened 11:24AM - 24 Dec 21 UTC

garrison

+20 -2

This adds `Irrational` support to `rem2pi` and thus fixes #42799. One thing tha…t is a bit awkward is that `rem2pi(π, r)` returns `π` in the form of an `Irrational` for each rounding mode _except_ `RoundUp`, where it instead returns the `Float64` equivalent of `-π`. I don't expect this will lead to type instability in practice, as typically the rounding mode is fixed in the code and is thus known at compile time. I also added a version that accepts any `Real`, so that e.g. the exponential constant ℯ can be passed. Admittedly, I don't see any real use case for calling with that constant in particular, but at least it works as expected now, and there are likely other, more useful, cases that will benefit from this. It also follows the practice of other methods (e.g. `sin`, `cos`), which do indeed accept this constant by converting it to a `float`. While making this change, I also changed the existing method specializing on `Int64` to specialize on `Integer` instead, as that method will work for any `Integer` that can be exactly converted to a `Float64`, whether it is an `Int16`, `Int32`, `Int64`, or even a `BigInt`.

Topic		Replies	Views
Complexifying pi General Usage	24	1345	May 6, 2019
Mod not defined for two identical irrationals General Usage question	8	774	April 4, 2018
How to understand place of numbers with Irrational type in Julia? New to Julia	2	1595	July 18, 2020
Trouble understanding rem_pio2_kernel Numerics	2	792	September 24, 2018
Type conversions with 2π (2pi) and how to avoid them General Usage	15	723	August 4, 2022

Rem2pi(pi) errors

Related topics