PR to stdlib

[yakir12]

I wanted to add “default” functionality to TemrinalMenus.jl (so one could specify a default pre-selected item/s to the menus).

1. So I ]dev TerminalMenus
2. changed stuff in .julia/dev/TerminalMenus
3. added documentations and tests (and tested it)
4. and wanted to change the remote to my fork so I could do a PR, but this is where I got stumped

What remote do I change this to? TemrinalMenu is a standard library, it doesn’t have a github-repository I can point at. I also failed to point to my fork of Julia:

$ git remote set-url origin git@github.com:yakir12/julia.git
$ git push
To github.com:yakir12/julia.git
 ! [rejected]        master -> master (fetch first)
error: failed to push some refs to 'git@github.com:yakir12/julia.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Not sure what I’m supposed to do.

Help.

Oh wait, does this mean that I need to work on julia master…? Just to contribute to a stdlib…? But then I’ll have to build julia locally?

Lord. Please be gentle.

[Tamas_Papp]

Did you branch? There are many descriptions on this forum, eg

Develop a local version of a registered package and submit changes as a pull request

I’ve been working through how one would go about making changes to a registered Julia package and submit the changes as a pull request. I haven’t found one source that explains the whole process, so I thought I’d share what I’ve come up with here. Let me know if anything seems wrong or if there are better ways to do this! Also, I did find a nice PR to the Pkg.jl repo that would add a lot of this to the Pkg docs, though the approach is slightly different from what I have below. You can use the…

Recommended way to develop/fix with packages

This is my workflow (for patching a hypothetical Example package): Get a local copy of the package, this can be done with pkg> develop Example. This will clone the package to ~.julia/dev/Example by default. It will also make sure that the local copy is the one that is “installed” in the sense that using Example will use the files in that local folder. Edit the package in ~.julia/dev/Example and make sure your changes work as you expect. Fork the package on GitHub and add your fork as a remote.…

A PR to the Julia repo is conceptually not different from making a PR to a package.

[yakir12]

Thank you Tamas.

@Tamas_Papp

There are many descriptions on this forum

I’m not qualified to do this, but it would have been good to have this all nicely curated in the docs (of Pkg perhaps). I’ll read up and try again.

[yakir12]

@Tamas_Papp

Did you branch?

OK, that was it. I did not. Thanks for knowing everything.

For anyone interested in the functionality itself, here’s the PR:

Defaults