(For anyone needing an excuse to procrastinate.) Is this a very julian way to write this? How could it be improved? function fizzbuzz(i, ps) s = [p.second for p in ps if p.first(i)] |> join return isempty(s) ? string(i) : s end ps = ((i->i%3==0) => "Fizz", (i->i%5==0) => "Buzz") fi…

Here’s a prosaic version I might write in “real code”: function fizzbuzz(i) f = i % 3 == 0 b = i % 5 == 0 f && b ? "FizzBuzz" : f ? "Fizz" : b ? "Buzz" : string(i) end for i in 1:20 println(fizzbuzz(i)) end Arguably this has the benefit of being straightf…

ps = ((i->i%3==0) => "Fizz", (i->i%5==0) => "Buzz", i->i%7 ==0)=>"Zap") function fizzbuzz(n,ps) res = "" for (key,value) in ps if key(n) == true res *= value end end if res == "" res *= string(n) end return res end julia> for i = 1…

[image] Adriel: s = [p.second for p in ps if p.first(i)] |> join maybe using a function to access the values rather that accessing the field directly? s = [last(p) for p in ps if first(p)(i)] |> join

Yes, this is boring. But I looked at my code less than 24 hours after writing it and didn’t immediately understand it! So maybe boring is not such a bad thing. Also, good point about removing allocations.

Thanks. As far as I can see this is essentially the same fizzbuzz, except it avoids creating an array of strings. Is that the point here?

I just wanted to do my own version :sweat_smile:, but there are esencially the same, as they use the same arguments.

Just realised the array allocation s = [p.second for p in ps if p.first(i)] |> join can be replaced with a generator. s = join(p.second for p in ps if p.first(i)) It’s faster too.

I’m so lazy here’s how I’d probably write it… FizzBuzz1(x) = ( (x % 3 == 0) ? "Fizz" : "") * ( (x % 5 == 0) ? "Buzz" : "") FizzBuzz1.(1:30) FizzBuzz2(x) = reduce( *, ["Fizz","Buzz"][(x .% [3,5]) .== 0]) FizzBuzz2.(1:30)

Awkward looks like I just failed my code interview! Here’s a quick monkey patch… function IfNothingThenX(fn, x) result = fn(x) return ( length(result) == 0 ) ? x : result end IfNothingThenX.(FizzBuzz1, 1:30) #Or... IfNothingThenX.(FizzBuzz2, 1:30)

The reduce version gets my vote!

Please critique my FizzBuzz!

General Usage

Topic		Replies	Views
Code-golfing FizzBuzz General Usage	86	3028	March 9, 2023
Best way to optimize code Performance question	29	2544	May 21, 2020
In as few lines as possible describe why you love julia New to Julia	113	13155	May 21, 2021
Loops, allocations and helping the coder Internals & Design	26	2387	October 10, 2023
Trying to understand how to write good code (example) New to Julia	34	3173	February 16, 2017

Please critique my FizzBuzz!

Related topics