Creating an Accounting Program in Julia, for Pluto

brett_knoss · June 2, 2021, 8:02pm

I explained that, i want to enter each value twice, because I want to ensure that it was entered correctly both times. Like, when your asked to renter a new password, or email, that is why I want a check.

oheil · June 2, 2021, 8:07pm

I accepted that already.
We are talking about ledger should be considered as being local.
And:

the return value in the case of no error
calculating check isn’t necessary, check what I provided:

	if credit_amount-debit_amount != 0
		return (false,"Error -- credit and debit must match.")
	elseif ...

This is the way to do this.
You did: calculating check at the beginning, and use it somewhere else. Thats not the way to do it. It’s a minor point.

brett_knoss · June 2, 2021, 8:08pm

Is it something that executes ledger inside of the transaction function?

function ledgertransaction!( 
		ledger, 
		date, 
		credit_account, 
		credit_amount, 
		debit_account, 
		debit_amount )
	
	ledger=DataFrame(
    	date=[],
    	chequing=[],
    	expenses=[],
    	income=[]);
end

function ledgertransaction(
    date,
    credit_account,
    credit_amount,
    debit_account,
    debit_amount
)
	
	ledgertransaction!( 
		date,
		credit_account,
		credit_amount,
		debit_account,
		debit_amount )
	
	check=credit_amount-debit_amount
	
	if length(date) == 0
		return(false,"Error-- no date entered")
	
	elseif !( credit_account in names(ledger) )
		
		return (false, "Error -- credit account not found.")
	
	elseif !( debit_account in names(ledger) )
		return (false, "Error--debit account not found")
		
	elseif check != 0				
		return (false,"Error -- credit and debit must match." )

	else
		return(true,"Journal Entry")
    		default_values=Dict("chequing"=>0,"expenses"=>0,"income"=>0)
    		spec = Dict(
				"date" => date, 
				credit_account => credit_amount, 
				debit_account => debit_amount)
		
    		row = merge(default_values, spec)
    
			push!(ledger,row)
       end
end

oheil · June 2, 2021, 8:11pm

Stay focused. You are jumping between the issues.
I decide, we focus now on the easiest: change your code according to:

calculating check isn’t necessary, check what I provided:
	if credit_amount-debit_amount != 0
		return (false,"Error -- credit and debit must match.")
	elseif ...
This is the way to do this.
You did: calculating check at the beginning, and use it somewhere else. Thats not the way to do it. It’s a minor point.

Any questions about this?

brett_knoss · June 2, 2021, 8:26pm

Ok, I did that because

if credit_amount != debit_amount

doesn’t work

but

if credit_amount-debit_amount != 0
return (false,“Error – credit and debit must match.”)
elseif …

does

oheil · June 2, 2021, 8:28pm

It should work:

           if credit_amount != debit_amount
               return (false,"Error -- credit and debit must match.")
           elseif length(date) == 0
               return (false,"Error -- no date entered")
           elseif ...

Please check, it should work!

brett_knoss · June 2, 2021, 8:29pm

It does.

oheil · June 2, 2021, 8:31pm

Great!

Next step:

the return value in the case of no error

What do you return in case of no error? What should we return?

brett_knoss · June 2, 2021, 8:33pm

	if length(date) == 0
		return(false,"Error-- no date entered")
	
	elseif !( credit_account in names(ledger) )
		
		return (false, "Error -- credit account not found.")
	
	elseif !( debit_account in names(ledger) )
		return (false, "Error--debit account not found")
		
	elseif credit_amount-debit_amount != 0			
		return (false,"Error -- credit and debit must match." )

	else
                return(true,journal_entry)
      end

oheil · June 2, 2021, 8:37pm

No, this is type unstable.

(And journal_entry shouldn’t be there at all! It is clear, that this is in your way to proceed. You try to solve problems before you have solved those you have before. That’s in your way, it’s blocking you. Remove journal_entry completely from your code!)

In case of an error you return a value of type Tuple{Bool,String} . We need to stick with this, thats what we have to return in any case.

brett_knoss · June 2, 2021, 8:40pm

if length(date) == 0
	return(false,"Error-- no date entered")

elseif !( credit_account in names(ledger) )
	
	return (false, "Error -- credit account not found.")

elseif !( debit_account in names(ledger) )
	return (false, "Error--debit account not found")
	
elseif credit_amount-debit_amount != 0			
	return (false,"Error -- credit and debit must match." )

else
            return(true, "there  are no errors")
  end

oheil · June 2, 2021, 8:44pm

Nice!
Let me see the whole function (no journal_entry please )

brett_knoss · June 2, 2021, 8:47pm

function ledgertransaction(
    date,
    credit_account,
    credit_amount,
    debit_account,
    debit_amount
)
	

	
	
	if length(date) == 0
		return(false,"Error-- no date entered")
	
	elseif !( credit_account in names(ledger) )
		
		return (false, "Error -- credit account not found.")
	
	elseif !( debit_account in names(ledger) )
		return (false, "Error--debit account not found")
		
	elseif credit_amount-debit_amount != 0			
		return (false,"Error -- credit and debit must match." )

	else
    		return(true, "there  are no errors")

		default_values=Dict("chequing"=>0,"expenses"=>0,"income"=>0)
    		spec = Dict(
				"date" => date, 
				credit_account => credit_amount, 
				debit_account => debit_amount)
		
    		row = merge(default_values, spec)
    
			push!(ledger,row)
	
			
		)

end

end

oheil · June 2, 2021, 8:49pm

This wouldn’t work as you expect it.

Tell me, what do you think, the line with the returns does?

What does the line

       return(true, "there  are no errors")

do?

brett_knoss · June 2, 2021, 9:12pm

returns a value from the function to the general program?

brett_knoss · June 2, 2021, 9:24pm

I think I need to go over how return works with functions.

oheil · June 2, 2021, 9:28pm

you are right, and what about the code after it? Is it ever reached?

brett_knoss · June 2, 2021, 9:30pm

No the code ends. Do I move return after ?

function ledgertransaction(
    date,
    credit_account,
    credit_amount,
    debit_account,
    debit_amount
)
	

	
	
	if length(date) == 0
		return(false,"Error-- no date entered")
	
	elseif !( credit_account in names(ledger) )
		
		return (false, "Error -- credit account not found.")
	
	elseif !( debit_account in names(ledger) )
		return (false, "Error--debit account not found")
		
	elseif credit_amount-debit_amount != 0			
		return (false,"Error -- credit and debit must match." )

	else
    	
		default_values=Dict("chequing"=>0,"expenses"=>0,"income"=>0)
    		spec = Dict(
				"date" => date, 
				credit_account => credit_amount, 
				debit_account => debit_amount)
		
    		row = merge(default_values, spec)
    
			push!(ledger,row)
	
		return(true, "there  are no errors")	

end

end

oheil · June 2, 2021, 9:55pm

Of course.
What’s this extra ) there in the line after the last return?

brett_knoss · June 2, 2021, 10:00pm

A mistake