We have a strange behaviour in our codecoverage that increased with our current redesign, so I would like to understand how this happens – and maybe how to avoid it. Here is an example
https://app.codecov.io/gh/JuliaManifolds/Manifolds.jl/compare/468/tree/src/manifolds/Euclidean.jl#D1L189
for the code at
function get_coordinates_diagonalizing!(
M::Euclidean,
Y,
p,
X,
::DiagonalizingOrthonormalBasis{ℝ},
)
S = representation_size(M)
PS = prod(S)
copyto!(Y, reshape(X, PS))
return Y
end
for. completeness:
function _get_coordinates!(M::AbstractManifold, Y, p, X, B::DiagonalizingOrthonormalBasis)
return get_coordinates_diagonalizing!(M, Y, p, X, B)
end
and here is (also for completeness) a screenshot of the current code coverage report
Where can this false report of a line that is covered but reported as uncovered come from?
2 Likes
We changed two things that actually resolved most of the problems
We were running code coverage with Julia 1.6 when I opened this topic. Now we are running with 1.7
We used the (old) @v1 upload GitHub Action from Codevov. We now switched to @v2.
