Hi all, TLDR: I made a Julia linter which shows rewrite suggestions online. At the time of writing it analyses 128 Julia repositories (about 1,012,728 lines of code) and shows the diffs. I was recently watching a video of SourceGraph Campaigns and found it super cool. Basically, it allows you to a…

Sorry if this is off topic, but why suggest turning x === missing to ismissing(x)? Especially when it seems to be fine with x === nothing?

@tlienart Thanks! I’ve added an issue for your first suggestion and am going to improve on that. For your second suggestion, I think that’s not possible yet. The site shows too many false positives. So far, I did find some interesting problems in code and created PRs manually: https://github.com/J…

[image] rikh: @Mason that’s not off topic. Are you sure that x === missing is the same as x === nothing ? I’m not an expert, so it could definitely be true. Would you mind elaborating a bit more? Both missing and nothing are defined as Missing() and Nothing() respectively, and ismissing and i…

I do expect that ismissing(x) is easier to read for new Julia users, and performance is not really the issue for most practical problems („premature optimization is the root of all evil“), but you might very well be right that its not an useful pattern to check for. I‘m gonna look into it a bit more…

Maybe these are relevant: `isnothing(x)` is slower than `x === nothing` (dispatch blocks vectorization?) opened 12:07PM - 24 Apr 20 UTC (UTC) closed 02:42PM - 24 Apr 20 UTC (UTC) …

That’s pretty dope and I’m happy that you analysed two of my repos :slight_smile: How long does it take to produces the results? Is it out of reach to do this for all registered packages?

Haha, you’re welcome Currently, it takes about 20 minutes ( https://github.com/rikhuijzer/ShowLint/actions ), so it’s not too bad. Good idea. I’ve put it in my task list ( https://github.com/rikhuijzer/ShowLint/issues/11 ).

@joa-quim In response to https://discourse.julialang.org/t/ismissing-x-versus-x-missing/52171/3: That’s why I’m working ShowLint with the possibility to disable lint patterns in bulk. Instead of adding a lint configuration to each project/repository, I could just disable the check for this pattern a…

Oh and maybe only lint the src folder as something like a == a can be helpful in testing to check if the function for == is correctly implemented.

[ANN] ShowLint

Package Announcements

rikh December 21, 2020, 1:30pm 8

I’ve opened a topic at Ismissing(x) versus x === missing.

Topic		Replies	Views
A playful competition: who can define a method that invalidates the most code? Tooling competition	44	3438	October 6, 2020
Invalidations findings (from a GMT case) General Usage performance	64	2190	January 12, 2023
The Julia Challenge Community	33	3524	November 20, 2018
Potential performance regressions in Julia 1.8 for special un-precompiled type dispatches and how to fix them Performance performance	25	3608	October 4, 2022
A most harrowing collection of Julia WATs General Usage wat	108	12789	January 27, 2024

[ANN] ShowLint

Related topics