I worked on generating and adding additional tests for SentinelArrays.jl here:
In the process I found another bug with findmax:
While I am glad the original issue was fixed, I’m wondering why the attention to the package was so narrow to ignore the other pull request addesssing perhaps the deeper issue - insufficient testing. I’m sure it was an oversight due to limited time.
Certainly when presented with a concrete bug the focus must not only be on fixing that bug but addressing why that bug was able to exist in the first place without being caught by CI.