Is OffsetArrays.jl a poison pill?

[jlapeyre]

@pdeffebach

If you are an end-user, you are free to do 1:length(x) whenever you want.

But usually when a newcomer asks about this, the response is “don’t do 1:length(x) or the world will come to an end.” The same holds for other best practices. We could be more nuanced when answering these questions.

Best practices

I am running a code which is diagonalizing very large matrices, hence I need to reach the best possible performance. when scanning a vector I was using the following syntax for i in 1:length(vec) which works fine. However, I am recently receiving the following warning Indexing with indices obtained from length, size etc is discouraged. Use eachindex or axes instead. Is it just a good practice? or the performance is also affected?