# General questions about Pull requests and reviews

**URL:** https://discourse.julialang.org/t/general-questions-about-pull-requests-and-reviews/55992
**Category:** Offtopic
**Tags:** question
**Created:** [February 25, 2021, 7:38am UTC](https://discourse.julialang.org/t/general-questions-about-pull-requests-and-reviews/55992 "2021-02-25T07:38:33Z")
**Posts on this page:** 3
**Page:** 1

<div class="post-metadata">

### Author: ![dev\_prithvitewatia](https://avatars.discourse-cdn.com/v4/letter/d/35a633/32.png) [@dev\_prithvitewatia](https://discourse.julialang.org/u/dev_prithvitewatia)
#### Post date: [February 25, 2021, 7:38am UTC](https://discourse.julialang.org/t/general-questions-about-pull-requests-and-reviews/55992/1 "2021-02-25T07:38:33Z")

</div>

Hello everyone, I am new to the Julia developer (Github) community though I have been using Julia for quite some time. I have few questions about the review of pull requests.

1. How much time can it take to review a pull request?
2. Who can review my pull request?
3. If my pull request does not get a review after a long time who can I contact?
4. I noticed that some pull requests had failing checks (like buildbot/tester\_linux32 or buildbot/tester\_win64) . So why do these checks fail and why the pull requests were still merged?

---

<div class="post-metadata">

### Author: ![Albert\_Zevelev](https://sea2.discourse-cdn.com/julialang/user_avatar/discourse.julialang.org/albert_zevelev/32/11844_2.png) [@Albert\_Zevelev](https://discourse.julialang.org/u/Albert_Zevelev)
#### Post date: [February 25, 2021, 7:46am UTC](https://discourse.julialang.org/t/general-questions-about-pull-requests-and-reviews/55992/2 "2021-02-25T07:46:22Z")

</div>

Welcome!

1. depends on the package/maintainers/the nature of the PR  
-sometimes the maintainers are busy  
-sometimes they are waiting for other features before they merge your PR…
2. the package maintainers
3. try to ping the package maintainers w/ @maintainer “friendly reminder”
4. something to do w/ code-coverage, continuous integration … ask someone else  
-just bc it doesn’t pass every test now, doesn’t mean it’s a bad PR & shouldn’t be merged  
-sometimes it doesn’t pass a test for a reason unrelated to your PR, & when that other reason is resolved your added code will pass more tests

---

<div class="post-metadata">

### Author: ![dev\_prithvitewatia](https://avatars.discourse-cdn.com/v4/letter/d/35a633/32.png) [@dev\_prithvitewatia](https://discourse.julialang.org/u/dev_prithvitewatia)
#### Post date: [February 25, 2021, 8:06am UTC](https://discourse.julialang.org/t/general-questions-about-pull-requests-and-reviews/55992/3 "2021-02-25T08:06:12Z")

</div>

Thanks
